Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: Error out on unknown/invalid attributes #943

Open
sdroege opened this issue Feb 1, 2023 · 3 comments · May be fixed by #970
Open

macros: Error out on unknown/invalid attributes #943

sdroege opened this issue Feb 1, 2023 · 3 comments · May be fixed by #970
Labels
glib-macros good first issue Good for newcomers
Milestone
0.18.0

Comments

@sdroege
Copy link
Member

sdroege commented Feb 1, 2023

E.g. the following should fail

#[derive(Debug, Copy, Clone, PartialEq, Eq, glib::Enum)]
#[enum_type(name = "MyEnum", nullable)]

Only name is valid in that context.
@sdroege sdroege added good first issue Good for newcomers glib-macros labels Feb 1, 2023
@sdroege sdroege added this to the 0.17.0 milestone Feb 1, 2023
@sdroege sdroege mentioned this issue Feb 1, 2023
Merged
@jf2048
Copy link
Member

jf2048 commented Feb 4, 2023

I just released a new crate deluxe that should make this a lot easier. I'd like to port the macros over to that, if it looks good?

@sdroege
Copy link
Member Author

sdroege commented Feb 5, 2023

Sounds good to me, you want to send a PR?

@jf2048 jf2048 linked a pull request Feb 7, 2023 that will close this issue
Draft
@sdroege sdroege modified the milestones: 0.17.0, 0.18.0 Feb 8, 2023
@zecakeh
Copy link
Contributor

zecakeh commented Apr 12, 2024

Isn't this fixed? With the example above, nullable is flagged with an error message. It seems that #1096 made it mandatory to have attribute validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
glib-macros good first issue Good for newcomers
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

RFC: glib-macros: port attribute parsing to use deluxe crate jf2048/gtk-rs-core
3 participants
@sdroege @zecakeh @jf2048