Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SimpleAction: take state by value" #1011

Merged
merged 1 commit into from Feb 17, 2023

Conversation

mbiggio
Copy link

@mbiggio mbiggio commented Feb 17, 2023

This reverts commit 42c72aa.

The generated bindings are leaking the state parameter

@mbiggio
Copy link
Author

mbiggio commented Feb 17, 2023

Solves #1009 for master

sdroege
sdroege previously approved these changes Feb 17, 2023
bilelmoussaoui
bilelmoussaoui previously approved these changes Feb 17, 2023
This reverts commit 42c72aa.

The generated bindings are leaking the state parameter
@mbiggio mbiggio dismissed stale reviews from bilelmoussaoui and sdroege via 4d10122 February 17, 2023 11:24
@mbiggio mbiggio force-pushed the wip/biggio/revert-simple-action branch from 5b58c14 to 4d10122 Compare February 17, 2023 11:24
@pbor pbor merged commit a683a43 into gtk-rs:master Feb 17, 2023
@mbiggio mbiggio deleted the wip/biggio/revert-simple-action branch February 17, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants