glib-macros: Specify quoted types explicitly #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the only two places where this is needed in the macros? |
|
I can check the others ones as well |
|
That would be great, thanks. I would be surprised if these were the only places :) To be even more correct, I think you'd do |
felinira
force-pushed
the
properties-specificity
branch
from
c2853d3
to
dda20dc
Compare
|
This was… quite a lot 😅 I opted to use |
felinira
changed the title
felinira
force-pushed
the
properties-specificity
branch
from
dda20dc
to
1189a23
Compare
bilelmoussaoui
previously approved these changes
Apr 1, 2023
sdroege
reviewed
Apr 1, 2023
felinira
force-pushed
the
properties-specificity
branch
from
1189a23
to
e79910c
Compare
sdroege
approved these changes
Apr 2, 2023
|
Thanks a lot :) I'll do a new bugfix release with this on Monday or Tuesday. |
sdroege
added
the
needs-backport
|
Done, this is in 0.17.7 now |
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a custom eg. result type in scope will fail compilation, as the types don't match. Specify quoted types explicitly to not rely on the prelude.