glib: Do not use ptr::offset/offset_from for private/impl offset #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix gstreamer-rs#470. |
sdroege
reviewed
Jun 6, 2023
sdroege
added
the
needs-backport
|
Should also make a 0.16 bugfix release with this. |
|
Also causes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/373 . Quite a horrible bug :) |
sdroege
force-pushed
the
no-offset
branch
2 times, most recently
from
b6c9508
to
5d0c621
Compare
sdroege
force-pushed
the
no-offset
branch
3 times, most recently
from
92662f4
to
dfa87bf
Compare
|
LGTM, thanks! |
Doing this violates Rust's [strict provenance rules][1]. Unfortunately, the API for doing this properly ([`ptr::expose_addr`][2]) isn't ready yet. However, we can work around this on stable Rust by casting through `isize` for offset calculations. [1]: https://doc.rust-lang.org/std/ptr/index.html [2]: https://doc.rust-lang.org/std/primitive.pointer.html#method.expose_addr Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
GuillaumeGomez
previously approved these changes
Jun 6, 2023
sdroege
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this violates Rust's strict provenance rules. Unfortunately, the API for doing this properly (
ptr::expose_addr) isn't ready yet. However, we can work around this on stable Rust by casting throughisizefor offset calculations.