Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate unit tuple in clone macro as default-return value #1138

Merged
merged 2 commits into from Jul 23, 2023
Merged

Don't generate unit tuple in clone macro as default-return value #1138

merged 2 commits into from Jul 23, 2023

Conversation

GuillaumeGomez
Copy link
Member

Fixes #1102.

@bilelmoussaoui
Copy link
Member

looks good to me, but i still believe the actual solution is to not use @default-return at all. Still good to merge though

@bilelmoussaoui bilelmoussaoui merged commit 11a9402 into gtk-rs:master Jul 23, 2023
46 checks passed
@GuillaumeGomez GuillaumeGomez deleted the unit-tuple branch July 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] glib::closure can cause clippy to complain
2 participants
@GuillaumeGomez @bilelmoussaoui