Added bindings for Gio.DBusObjectManager, Gio.DBusObjectManagerClientFlags #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to re-run the generator as there are no bindings generated as you can tell. |
|
Unfortunately I can't. I tried to explain that for some reason I get a ton of formatting changes when I regenerate the code and it becomes difficult to see the changes of this PR. |
pentamassiv
force-pushed
the
dbusObjectMgr
branch
from
804765b
to
523074d
Compare
|
Sorry, nevermind. It works. I previously ran gir directly and did not use the python script. It works when using the python script |
bilelmoussaoui
added
the
needs-backport
pentamassiv
force-pushed
the
dbusObjectMgr
branch
from
523074d
to
586b18f
Compare
pentamassiv
force-pushed
the
dbusObjectMgr
branch
2 times, most recently
from
6b9f8dd
to
e745005
Compare
pentamassiv
force-pushed
the
dbusObjectMgr
branch
from
e745005
to
fea34b5
Compare
bilelmoussaoui
approved these changes
Aug 6, 2023
bilelmoussaoui
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the above mentioned objects are not generated. I am currently working on updated bindings for Gnome Online Accounts and some of the code can't be generated because they are missing from gio.
For some reason I get a ton of formatting changes after regenerating the code, so I first regenerated before doing changes. Then I added them to the Gir.toml file and regenerated the bindings again. There were only the expected lines to uncommented after that. I ran
cargo buildandcargo testwithout any issues.Because I don't know why I had all these formatting changes, I did not include any of the regeneration commits.