Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: Remove #[doc(hidden)] from once_cell and bitflags re-export #1177

Merged
merged 1 commit into from Sep 6, 2023

Conversation

RealKC
Copy link
Contributor

@RealKC RealKC commented Sep 6, 2023

The blogpost1 mentions that these are re-exported, so to avoid causing confusion, make it so these appear in documentation.


Alternatives:

  • do nothing
  • remove the note about the two crates being re-exported from the blogpost

The blogpost[1] mentions that these are re-exported, so to avoid causing
confusion, make it so these appear in documentation.

[1]: https://gtk-rs.org/blog/2023/08/28/new-release.html#switch-to-bitflags-20
Copy link
Member

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with "publicly" re-exporting them. Even if I am looking forward to Lazy being in the std so we can fully drop the once_cell usage.

@RealKC
Copy link
Contributor Author

RealKC commented Sep 6, 2023

Even if I am looking forward to Lazy being in the std so we can fully drop the once_cell usage.

Yeah that's something I'm looking forward for my personal projects as well

@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Sep 6, 2023
@sdroege sdroege merged commit 5d8479c into gtk-rs:master Sep 6, 2023
47 checks passed
@bilelmoussaoui bilelmoussaoui added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR was backported to the current stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants