glib: Allow variable expansion in format strings passed to bool_error & result_from_gboolean #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Oct 21, 2023
sdroege
approved these changes
Oct 21, 2023
|
Thanks! |
bilelmoussaoui
added
the
needs-backport
gstreamer-github
pushed a commit
to sdroege/gst-plugin-rs
that referenced
this pull request
Oct 21, 2023
loggable_error! can now expand variables and we no longer need the format! on our side. gtk-rs/gtk-rs-core#1210 Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1366>
|
@bilelmoussaoui I don't believe this change can be backported as it is actually a breaking change, previously |
|
Yes, this can't be backported unfortunately. |
sdroege
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to go about it
Fixes #1209