Fix / work around a couple of new clippy 1.75 warnings #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
commented
Dec 22, 2023
| @@ -228,8 +228,8 @@ pub use crate::{ | |||
| enums::*, | |||
| error::{BorrowError, Error, IoError, Result}, | |||
| font::{ | |||
| FontExtents, FontFace, FontOptions, FontSlant, FontType, FontWeight, Glyph, ScaledFont, | |||
| TextCluster, TextExtents, UserFontFace, | |||
There was a problem hiding this comment.
I would've said that this should get a bugfix release but considering that nobody noticed the lack of those types in the public API for years....
pbor
approved these changes
Dec 22, 2023
|
@GuillaumeGomez Any idea what's with https://github.com/gtk-rs/gtk-rs-core/actions/runs/7300850123/job/19896312494?pr=1254 ? This fails regularly now since recently. |
|
Absolutely no idea. :-/ |
|
It also does not fail always, just often 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.