Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor macros to register dynamic types #1255

Merged
merged 3 commits into from Dec 23, 2023

Conversation

fbrouille
Copy link
Contributor

This PR aims to refactor the macros to register dynamic types, by replacing a macro by a macro helper attribute for object_subclass, object_interface and Enum

…te 'enum_dynamic' for derive macro 'Enum'

Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
… 'object_subclass_dynamic' for macro 'object_subclass'

Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
…e 'object_interface_dynamic' for macro 'object_interface'

Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and nicer than before. Thanks!

@pbor what do you think?

Copy link
Contributor

@pbor pbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks nicer!

@sdroege sdroege merged commit 279063e into gtk-rs:master Dec 23, 2023
48 checks passed
@fbrouille fbrouille deleted the refactor_api_dynamic_types branch December 24, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants