Fix concurrency issues #1256
Merged
Fix concurrency issues #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amic' Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
sdroege
reviewed
Dec 24, 2023
| /// Do nothing as the object interface has been registered on implementation load. | ||
| #[inline] | ||
| fn register_interface() -> #crate_ident::Type { | ||
| unsafe { <#crate_ident::Type as #crate_ident::translate::FromGlib<#crate_ident::ffi::GType>>::from_glib(*Self::get_type_mut()) } | ||
| let gtype = #gtype_status.load(::std::sync::atomic::Ordering::Relaxed); |
There was a problem hiding this comment.
Is this somewhere protected also via a mutex? Otherwise it would probably be safer to use SeqCst here
There was a problem hiding this comment.
No mutex here, I thought atomic was enough. But yes Relaxed is a weak memory ordering and other threads might not see the change 'immediately' (however this is not really a problem because a type can be registered several times and Glib system always return the same GType value). For synchronization purpose, maybe SeqCst is too strong. I think Acquire and Release are enough here.
There was a problem hiding this comment.
Yes, Acquire / Release seems to be enough here
…namic' Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
fbrouille
force-pushed
the
fix_concurrency_issues
branch
from
3480a0e
to
64c305c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the concurrency issues in code generated by the macro helper attributes
object_subclass_dynamicandobject_interface_dynamic