add support of flags registered as dynamic types #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
…ues to use EnumerationValuesStorages<E>/EnumerationValues<E> Signed-off-by: fbrouille <fbrouille@users.noreply.github.com>
fbrouille
force-pushed
the
flags_dynamic
branch
from
30ac7f1
to
8d3ac91
Compare
sdroege
reviewed
Jan 14, 2024
| impl<E: EnumerationValue<E>, const S: usize> EnumerationValuesStorage<E, S> { | ||
| // rustdoc-stripper-ignore-next | ||
| /// creates a new `EnumerationValuesStorage` with the given values and a final zero value. | ||
| pub const fn new<const N: usize>(values: [E; N]) -> Self { |
There was a problem hiding this comment.
This fails compiling if N + 1 != S, right?
There was a problem hiding this comment.
yes, e.g. if S = N = 3, it fails with:
error[E0308]: mismatched types
...
= note: expected array `[FlagsValue; 4]`
found array `[FlagsValue; 3]`
sdroege
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Looks good to me otherwise. Thanks!
@pbor @bilelmoussaoui what do you think?
pbor
reviewed
Jan 14, 2024
pbor
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
It is consistent with all that was already added by @fbrouille for enums etc, so I am good with getting this in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support of flags registered as dynamic types. See https://docs.gtk.org/gobject/class.TypeModule.html and https://docs.gtk.org/gobject/iface.TypePlugin.html.
The new macro
flags_dynamicallows to register the flags that are part of a module or of a plugin (e.g. a shared library on linux). This helper macro generates code that support registration when the plugin (TypePlugin) is used, following the behavior defined in Glib doc. However it is possible to postpone the registration at first use of the flags by explicitly setting the macro attributelazy_registration = true.