Activate dox feature wherever available #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2022
gdk-pixbuf/sys/Cargo.toml
Outdated
| @@ -21,7 +21,7 @@ shell-words = "1.0.0" | |||
| tempfile = "3" | |||
|
|
|||
| [features] | |||
| dox = [] | |||
| dox = ["glib/dox", "gio/dox", "gobject/dox"] | |||
There was a problem hiding this comment.
You will have to teach gir as it is what generates the sys/Cargo.toml to do this automatically.
There was a problem hiding this comment.
Okay, I'll try that instead.
|
Fixed, since #798 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a crate is published on crates.io, its documentation is automatically built on docs.rs regardless of the documentation field in the Cargo.toml file. On docs.rs it is possible to look at all previous versions. This is why there is value in having working builds on docs.rs. Having broken builds on docs.rs also prevents crates using that library from providing their documentation on docs.rs. Analogous to https://gitlab.gnome.org/World/Rust/libadwaita-rs/-/merge_requests/50, I enabled the dox feature wherever it is available to ensure the docs always build, even if the dependencies are not available.
I also fixed a broken link in the documentation