Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Implement embed-lgpl-docs and purge-lgpl-docs features #245

Merged
merged 3 commits into from
Feb 22, 2016
Merged

Implement embed-lgpl-docs and purge-lgpl-docs features #245

merged 3 commits into from
Feb 22, 2016

Conversation

gkoz
Copy link
Member

@gkoz gkoz commented Feb 3, 2016

Part of #8

embed-lgpl-docs: embed documentation comments contained in the gtk-rs-lgpl-docs package into the sources.
purge-lgpl-docs: remove all LGPL doc comments from the source.

@gkoz gkoz changed the title Implement insert_lgpl_docs and remove_lgpl_docs features Implement embed_lgpl_docs and remove_lgpl_docs features Feb 3, 2016
@GuillaumeGomez
Copy link
Member

Maybe specify that such features exist and even add a little example in the README is needed here.

@gkoz
Copy link
Member Author

gkoz commented Feb 3, 2016

I wouldn't want to advertise these features before the docs repo is populated and ready to accept PRs from users wanting to improve the docs.

@GuillaumeGomez
Copy link
Member

Then we'd better wait before merging this PR.

@gkoz
Copy link
Member Author

gkoz commented Feb 3, 2016

After thinking about format changes a little it might be preferable to make gtk-rs-lgpl-docs depend on stripper_lib and move the substance of the code from this PR there. The code won't be duplicated across build scripts then and the lgpl-docs crate will always depend on the compatible version of stripper_lib (one that understands the particular cmts format).

@GuillaumeGomez
Copy link
Member

Since stripper_lib has been created, why not using it? ^^

@gkoz gkoz changed the title Implement embed_lgpl_docs and remove_lgpl_docs features Implement embed_lgpl_docs and purge_lgpl_docs features Feb 3, 2016
@gkoz
Copy link
Member Author

gkoz commented Feb 3, 2016

Implemented the idea from my last comment.

Part of #8

`embed-lgpl-docs`: embed documentation comments contained in the gtk-rs-lgpl-docs package into the sources.
`purge-lgpl-docs`: remove all LGPL doc comments from the source.
Fail if some unpurged docs slip in.
Run tests (there aren't any) and doctests.
@gkoz gkoz changed the title Implement embed_lgpl_docs and purge_lgpl_docs features Implement embed-lgpl-docs and purge-lgpl-docs features Feb 22, 2016
@gkoz
Copy link
Member Author

gkoz commented Feb 22, 2016

I think this is good to go.

@GuillaumeGomez
Copy link
Member

Thanks!

GuillaumeGomez added a commit that referenced this pull request Feb 22, 2016
Implement `embed-lgpl-docs` and `purge-lgpl-docs` features
@GuillaumeGomez GuillaumeGomez merged commit c06065e into gtk-rs:master Feb 22, 2016
EPashkin pushed a commit to EPashkin/gtk that referenced this pull request Apr 18, 2016
Make set_text methods take &str not String
alex179ohm pushed a commit to alex179ohm/gtk that referenced this pull request Oct 21, 2019
Fix `+IsA<Object>` without active signals in gesture.rs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants