New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more missing Gtk types #443

Merged
merged 2 commits into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@Susurrus
Contributor

Susurrus commented Feb 8, 2017

Partially address #442.

Haven't used any of this code, but didn't see any warnings about generating it. There were some GTK types that can't be generated, so I commented them out. Should I add them to the ignore list instead?

Show outdated Hide outdated Gir.toml Outdated
Show outdated Hide outdated src/auto/border.rs Outdated
Show outdated Hide outdated src/auto/target_list.rs Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 8, 2017

Member

Strange that it builds, as I remember WidgetPath has mixed const/mut* usage and fails.

Member

EPashkin commented Feb 8, 2017

Strange that it builds, as I remember WidgetPath has mixed const/mut* usage and fails.

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Feb 8, 2017

Contributor

I think I resolved all of your comments, so here's another batch of changes. Sorry about not checking over the generated code, I looked over the remaining generated types and they all seemed to have enough useful methods to be worthwhile.

Contributor

Susurrus commented Feb 8, 2017

I think I resolved all of your comments, so here's another batch of changes. Sorry about not checking over the generated code, I looked over the remaining generated types and they all seemed to have enough useful methods to be worthwhile.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 8, 2017

Member

Seems ok for me. Anything else for you @EPashkin?

Member

GuillaumeGomez commented Feb 8, 2017

Seems ok for me. Anything else for you @EPashkin?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 8, 2017

Member

style_context.rs don't builds on gtk/v3_20.
Function to_string conflict in impl fmt::Display for StyleContext
Gir need change to don't generate this impl for nonstandard functions.
@GuillaumeGomez, seems all good.

Member

EPashkin commented Feb 8, 2017

style_context.rs don't builds on gtk/v3_20.
Function to_string conflict in impl fmt::Display for StyleContext
Gir need change to don't generate this impl for nonstandard functions.
@GuillaumeGomez, seems all good.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 8, 2017

Member

@EPashkin: I merge then.
@Susurrus: Thanks!

Member

GuillaumeGomez commented Feb 8, 2017

@EPashkin: I merge then.
@Susurrus: Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 344453c into gtk-rs:master Feb 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Feb 8, 2017

Contributor

Given the fix in #313 I think there'll need to be another regent to make StylrContext correct, yes?

Contributor

Susurrus commented Feb 8, 2017

Given the fix in #313 I think there'll need to be another regent to make StylrContext correct, yes?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 8, 2017

Member

I already made PR, but forgot link this.

Member

EPashkin commented Feb 8, 2017

I already made PR, but forgot link this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment