Add more missing Gtk types #443
Conversation
Gir.toml
Outdated
| @@ -175,7 +182,13 @@ generate = [ | |||
| "Gtk.StateType", | |||
| "Gtk.Statusbar", | |||
| "Gtk.StatusIcon", | |||
| "Gtk.Style", | |||
There was a problem hiding this comment.
Its deprecated in 3.0, so better don't generate.
src/auto/border.rs
Outdated
| use glib::translate::*; | ||
|
|
||
| glib_wrapper! { | ||
| pub struct Border(Boxed<ffi::GtkBorder>); |
There was a problem hiding this comment.
Without fields it IMHO unusable
src/auto/target_list.rs
Outdated
| } | ||
|
|
||
| impl TargetList { | ||
| //pub fn new(targets: /*Ignored*/&[&TargetEntry], ntargets: u32) -> TargetList { |
There was a problem hiding this comment.
No reason to generate record without constructors
|
Strange that it builds, as I remember |
|
I think I resolved all of your comments, so here's another batch of changes. Sorry about not checking over the generated code, I looked over the remaining generated types and they all seemed to have enough useful methods to be worthwhile. |
|
Seems ok for me. Anything else for you @EPashkin? |
|
style_context.rs don't builds on gtk/v3_20. |
|
Given the fix in #313 I think there'll need to be another regent to make StylrContext correct, yes? |
|
I already made PR, but forgot link this. |
Partially address #442.
Haven't used any of this code, but didn't see any warnings about generating it. There were some GTK types that can't be generated, so I commented them out. Should I add them to the
ignorelist instead?