New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StyleContext::{get_color, lookup_color} #462

Merged
merged 2 commits into from Mar 11, 2017

Conversation

Projects
None yet
3 participants
@Susurrus
Contributor

Susurrus commented Mar 6, 2017

This is done manually because the RGBA struct isn't generally usable by gir yet.

Closes #454.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 6, 2017

Member

Comment about closing must go to first comment to work.

Member

EPashkin commented Mar 6, 2017

Comment about closing must go to first comment to work.

Show outdated Hide outdated src/color_chooser.rs Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 8, 2017

Member

I add few comments to reminder, it mainly for case when gtk-rs/gdk#140 selected to merge.

Member

EPashkin commented Mar 8, 2017

I add few comments to reminder, it mainly for case when gtk-rs/gdk#140 selected to merge.

Show outdated Hide outdated src/color_chooser.rs Outdated
Show outdated Hide outdated src/color_chooser.rs Outdated
Show outdated Hide outdated src/style_context.rs Outdated
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 8, 2017

Contributor

@EPashkin Just pushed new commits that should resolve all your comments.

Contributor

Susurrus commented Mar 8, 2017

@EPashkin Just pushed new commits that should resolve all your comments.

Show outdated Hide outdated src/color_chooser.rs Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 8, 2017

Member

@Susurrus Sorry, but after RGBA have glib::Value support you need use generated code for it.
So manual style_context.rs no longer needed.

Member

EPashkin commented Mar 8, 2017

@Susurrus Sorry, but after RGBA have glib::Value support you need use generated code for it.
So manual style_context.rs no longer needed.

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 8, 2017

Contributor

@EPashkin Yeah, that makes more sense! Cool, that enables a bunch more functions too, including one that was already manually implemented, so that's nice. Hopefully this is now correct.

Contributor

Susurrus commented Mar 8, 2017

@EPashkin Yeah, that makes more sense! Cool, that enables a bunch more functions too, including one that was already manually implemented, so that's nice. Hopefully this is now correct.

Show outdated Hide outdated src/color_button.rs Outdated
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 8, 2017

Contributor

I've removed the set_rgba and get_rgba functions as you asked.

Also, with the addition of the RGBA type, the auto-generated code now includes StyleContext::GetBackgroundColor and StyleContext::GetBorderColor, both of which are deprecated as of 3.16. Should I disable their autogeneration or leave them?

Contributor

Susurrus commented Mar 8, 2017

I've removed the set_rgba and get_rgba functions as you asked.

Also, with the addition of the RGBA type, the auto-generated code now includes StyleContext::GetBackgroundColor and StyleContext::GetBorderColor, both of which are deprecated as of 3.16. Should I disable their autogeneration or leave them?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 8, 2017

Member

Thanks.
Ignoring not needed.
We ignore only functions, that deprecated by v3.4.
It controlled by Gir.toml parameters min_cfg_version and deprecate_by_min_version

Member

EPashkin commented Mar 8, 2017

Thanks.
Ignoring not needed.
We ignore only functions, that deprecated by v3.4.
It controlled by Gir.toml parameters min_cfg_version and deprecate_by_min_version

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 8, 2017

Contributor

Okay, so I don't need to do anything about those two functions then?

Contributor

Susurrus commented Mar 8, 2017

Okay, so I don't need to do anything about those two functions then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 8, 2017

Member

Yes, this functions stays as is, deprecation will noted on docs as for http://gtk-rs.org/docs/gtk/prelude/trait.WidgetExt.html#tymethod.drag_source_set_icon_stock

Member

EPashkin commented Mar 8, 2017

Yes, this functions stays as is, deprecation will noted on docs as for http://gtk-rs.org/docs/gtk/prelude/trait.WidgetExt.html#tymethod.drag_source_set_icon_stock

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 11, 2017

Member

@GuillaumeGomez Maybe merge this before PR's related to gtk-rs/examples#112 ?

Member

EPashkin commented Mar 11, 2017

@GuillaumeGomez Maybe merge this before PR's related to gtk-rs/examples#112 ?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 11, 2017

Member

And another one I forgot... Thanks @EPashkin for the reminder and thanks a lot @Susurrus for the PR!

Member

GuillaumeGomez commented Mar 11, 2017

And another one I forgot... Thanks @EPashkin for the reminder and thanks a lot @Susurrus for the PR!

@GuillaumeGomez GuillaumeGomez merged commit 974759d into gtk-rs:master Mar 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 11, 2017

Contributor

Awesome, thanks for helping through implementing this @GuillaumeGomez and @EPashkin!

Contributor

Susurrus commented Mar 11, 2017

Awesome, thanks for helping through implementing this @GuillaumeGomez and @EPashkin!

@Susurrus Susurrus referenced this pull request Mar 12, 2017

Closed

Builds failing since #464 #465

@EPashkin EPashkin referenced this pull request Mar 21, 2017

Merged

Remove manual duplicate #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment