New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_process.md #504

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented May 6, 2017

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 6, 2017

Member

@EPashkin: So, for the master branch, should we be equal with the crate branch's version or ahead of one?

Member

GuillaumeGomez commented May 6, 2017

@EPashkin: So, for the master branch, should we be equal with the crate branch's version or ahead of one?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 6, 2017

Member

IMHO it need be equal and changed before merging to crate.
Offtopic, also I don't see reason having dependency version in Cargo.toml of master branch: in docs shown only noncrate use of version in path override dependency
Edit: fix

Member

EPashkin commented May 6, 2017

IMHO it need be equal and changed before merging to crate.
Offtopic, also I don't see reason having dependency version in Cargo.toml of master branch: in docs shown only noncrate use of version in path override dependency
Edit: fix

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 6, 2017

Member

I didn't understand the second part of your comment.

Member

GuillaumeGomez commented May 6, 2017

I didn't understand the second part of your comment.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 6, 2017

Member

I just thought: I will write a full release script because right now, it's just too long and easy to make mistakes.

Member

GuillaumeGomez commented May 6, 2017

I just thought: I will write a full release script because right now, it's just too long and easy to make mistakes.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 7, 2017

Member

We have version in dependencies https://github.com/gtk-rs/gtk/blob/master/Cargo.toml#L47 but seems cargo only used it to check max version. And I only found use version on path dependency http://doc.crates.io/specifying-dependencies.html#specifying-path-dependencies.

Member

EPashkin commented May 7, 2017

We have version in dependencies https://github.com/gtk-rs/gtk/blob/master/Cargo.toml#L47 but seems cargo only used it to check max version. And I only found use version on path dependency http://doc.crates.io/specifying-dependencies.html#specifying-path-dependencies.

@GuillaumeGomez GuillaumeGomez merged commit f80ae7a into master May 19, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the update branch May 19, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 19, 2017

Member

Long forgotten ;)
Thanks.

Member

EPashkin commented May 19, 2017

Long forgotten ;)
Thanks.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 19, 2017

Member

Indeed haha.

Member

GuillaumeGomez commented May 19, 2017

Indeed haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment