Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Update release_process.md #504

Merged
merged 1 commit into from May 19, 2017
Merged

Update release_process.md #504

merged 1 commit into from May 19, 2017

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@GuillaumeGomez
Copy link
Member Author

@EPashkin: So, for the master branch, should we be equal with the crate branch's version or ahead of one?

@EPashkin
Copy link
Member

EPashkin commented May 6, 2017

IMHO it need be equal and changed before merging to crate.
Offtopic, also I don't see reason having dependency version in Cargo.toml of master branch: in docs shown only noncrate use of version in path override dependency
Edit: fix

@GuillaumeGomez
Copy link
Member Author

I didn't understand the second part of your comment.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 6, 2017

I just thought: I will write a full release script because right now, it's just too long and easy to make mistakes.

@EPashkin
Copy link
Member

EPashkin commented May 7, 2017

We have version in dependencies https://github.com/gtk-rs/gtk/blob/master/Cargo.toml#L47 but seems cargo only used it to check max version. And I only found use version on path dependency http://doc.crates.io/specifying-dependencies.html#specifying-path-dependencies.

@GuillaumeGomez GuillaumeGomez merged commit f80ae7a into master May 19, 2017
@GuillaumeGomez GuillaumeGomez deleted the update branch May 19, 2017 18:34
@EPashkin
Copy link
Member

Long forgotten ;)
Thanks.

@GuillaumeGomez
Copy link
Member Author

Indeed haha.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants