GString support

[philn]

No description provided.

[philn]

I suppose this one needs a rebase.

[sdroege]

Yeah, but otherwise good to go. Not sure why it was not merged before. @GuillaumeGomez ?

[GuillaumeGomez]

Never took the time to look at the monstruous diff (sorry....).

[philn]

I did a fresh regen, and boom. 1483 errors, mostly:

   --> src/auto/list_store.rs:16:1                                                                                                                                                                  
    |                                                                                                                                                                                               
16  | / glib_wrapper! {                                                                                                                                                                             
17  | |     /// The `ListStore` object is a list model for use with a `TreeView`                                                                                                                    
18  | |     /// widget. It implements the `TreeModel` interface, and consequentialy,                                                                                                                
19  | |     /// can use all of the methods available there. It also implements the                                                                                                                  
...   |                                                                                                                                                                                             
162 | |     }                                                                                                                                                                                       
163 | | }                                                                                                                                                                                           
    | |_^ use of undeclared type or module `ptr`                                                                                                                                                    
    |                                                                                                                                                                                               
    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)                                                   
                                                                                                                                                                                                    
error[E0433]: failed to resolve: use of undeclared type or module `mem`                                                                                                                             
   --> src/auto/list_store.rs:16:1                                                                                                                                                                  
    |                                                                                                                                                                                               
16  | / glib_wrapper! {                                                                                                                                                                             
17  | |     /// The `ListStore` object is a list model for use with a `TreeView`                                                                                                                    
18  | |     /// widget. It implements the `TreeModel` interface, and consequentialy,                                                                                                                
19  | |     /// can use all of the methods available there. It also implements the                                                                                                                  
...   |                                                                                                                                                                                             
162 | |     }                                                                                                                                                                                       
163 | | }                                                                                                                                                                                           
    | |_^ use of undeclared type or module `mem`                                                                                                                                                    
    |                                                                                                                                                                                               
    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)                

[EPashkin]

Maybe you use old glib?
Its builds fine for me after rebase.

[EPashkin]

All I done as extra is removed unused in manual app_chooser.rs, border.rs, entry_buffer.rs

-use glib_ffi;
-use gobject_ffi;
-use std::ptr;
-use std::mem;

[philn]

Ah yes, once again I forgot to cargo update :)

[EPashkin]

Seems cargo build --features purge-lgpl-docs broken 😢
cc @GuillaumeGomez

[GuillaumeGomez]

Urg. Well, I'll take a look when I can. :-/

[philn]

Now without the lgpl docs, should make CI happier :)

[EPashkin]

Here docs still present

[EPashkin]

Seems it instead with LGLP docs

[philn]

Yes I don't know why gir generate those. The config file specifies "normal" mode... looks like another bug in gir.

[EPashkin]

Strange but cargo build --features purge-lgpl-docs works fine for me locally

[EPashkin]

@philn seems you run cargo test --features embed-lgpl-docs after regen and in previous run too.
@GuillaumeGomez Oh, it standard error with inverted diff, don't worry: purge works fine.

[philn]

Good to go now.

[EPashkin]

@philn Seems you forgot to update gir submodule: https://travis-ci.org/gtk-rs/gtk/jobs/478798815#L739,
but at minimum docs check now passes.

[philn]

It's updated there, eca9399 as part of this PR

[EPashkin]

Submodule updated to c5498ac, but you used last master 11adffa to regen

[EPashkin]

As it produce same code you can just change versions.txt to c5498ac if don't want do rebase

[philn]

Rebased :)

[EPashkin]

Thanks, clippy give errors: https://travis-ci.org/gtk-rs/gtk/jobs/478811268#L1372-L1378,
but IMHO we can ignore it in this PR as there other PRs planned.

error: casting from `*mut ffi::GtkRecentChooser` to a more-strictly-aligned pointer (`*mut gobject_ffi::GObject`)
   --> src/auto/recent_chooser.rs:329:25
    |
329 |             connect_raw(self.to_glib_none().0 as *mut _, b"notify::filter\0".as_ptr() as *const _,
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment

[EPashkin]

Ok, CI ended, 2 travis jobs failed by clippy.
@GuillaumeGomez This PR IMHO ready for merge too

[GuillaumeGomez]

I approve. Thanks @philn!