Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-init assertion to check for non-debug GTK builds #822

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Jun 6, 2019

While previously checking for this could be used to determine if GTK was
built with assertions enabled or not, this is not true anymore with
later versions of GTK. There is no way to know if assertions were
disabled or not at runtime.

While disabling assertions easily causes memory unsafety in GTK code,
it is nothing that can be disabled accidentally. Users deploying and
running such code will have to live with the consequences.

Fixes #821

Remove pre-init assertion to check for non-debug GTK builds
While previously checking for this could be used to determine if GTK was
built with assertions enabled or not, this is not true anymore with
later versions of GTK. There is no way to know if assertions were
disabled or not at runtime.

While disabling assertions easily causes memory unsafety in GTK code,
it is nothing that can be disabled accidentally. Users deploying and
running such code will have to live with the consequences.

Fixes #821

@sdroege sdroege referenced this pull request Jun 6, 2019

Closed

New release #73

10 of 10 tasks complete
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

@GuillaumeGomez All green except for the well-known Windows failure :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Waiting for @EPashkin approval before.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@sdroege Thanks 👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 5908ecf into gtk-rs:master Jun 6, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.