Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subclass: Implement subclassing for GtkStack #879

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@BrainBlasted
Copy link
Contributor

BrainBlasted commented Aug 16, 2019

Like EventBox this is an empty trait and override_vfuncs.

@BrainBlasted BrainBlasted mentioned this pull request Aug 17, 2019
40 of 43 tasks complete
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 17, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

Looks good but please rebase first. :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 2, 2019

@BrainBlasted can you rebase so we can merge?

Like EventBox this is an empty trait and `override_vfuncs`.
@BrainBlasted BrainBlasted force-pushed the BrainBlasted:stack-subclass branch from dd92c1c to b4ca1b3 Oct 7, 2019
@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Oct 7, 2019

Sorry it took me so long. Rebased.

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Oct 7, 2019

This no longer works because the "subclassing" feature seems to be removed? What happened here?

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Oct 7, 2019

Nevermind, figured it out.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Oct 7, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Oct 7, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 970ad70 into gtk-rs:master Oct 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.