Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AccelGroup::connect() and ::connect_by_path() more usable #915

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Nov 19, 2019

By renaming it to connect_accel_group() for preventing conflicts with
Object::connect() and by taking a normal Rust closure with fixed types
as arguments instead of a generic glib::Closure.

Return the generated glib::Closure as it is required for usage with a
few of the other AccelGroup and AccelLabel functions.

Fixes #913


CC @upsuper does this work better for you?

By renaming it to connect_accel_group() for preventing conflicts with
Object::connect() and by taking a normal Rust closure with fixed types
as arguments instead of a generic glib::Closure.

Return the generated glib::Closure as it is required for usage with a
few of the other AccelGroup and AccelLabel functions.

Fixes #913
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 19, 2019

👍

@sdroege sdroege mentioned this pull request Nov 19, 2019
40 of 43 tasks complete
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 19, 2019

@GuillaumeGomez CI is green :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 19, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e55bd4d into gtk-rs:master Nov 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.