This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Make AccelGroup::connect() and ::connect_by_path() more usable #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By renaming it to connect_accel_group() for preventing conflicts with Object::connect() and by taking a normal Rust closure with fixed types as arguments instead of a generic glib::Closure. Return the generated glib::Closure as it is required for usage with a few of the other AccelGroup and AccelLabel functions. Fixes #913
EPashkin
reviewed
Nov 19, 2019
|
👍 |
|
@GuillaumeGomez CI is green :) |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By renaming it to connect_accel_group() for preventing conflicts with
Object::connect() and by taking a normal Rust closure with fixed types
as arguments instead of a generic glib::Closure.
Return the generated glib::Closure as it is required for usage with a
few of the other AccelGroup and AccelLabel functions.
Fixes #913
CC @upsuper does this work better for you?