This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Add vfuncs to WidgetImpl #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- realize - unrealize - map - unmap - motion_notify_event
sdroege
suggested changes
Mar 12, 2020
|
I've applied the suggested changes and renamed a variable for clarity. The CI came up red before because of what looked like a network error to me. I just wanted to mention that too. |
Happens :) |
sdroege
reviewed
Mar 13, 2020
src/subclass/widget.rs
Outdated
Comment on lines
846
to
849
| let f = (*parent_class) | ||
| .realize | ||
| .expect("No parent class impl for \"realize\""); | ||
| f(widget.to_glib_none().0) |
There was a problem hiding this comment.
Suggested change
| let f = (*parent_class) | |
| .realize | |
| .expect("No parent class impl for \"realize\""); | |
| f(widget.to_glib_none().0) | |
| if let Some(f) = (*parent_class).realize { | |
| f(widget.to_glib_none().0); | |
| } |
And the same for unrealize, map, unmap and motion_notify_event. They're all optional and nothing bad (and nothing at all) happens when they are not set.
For the motion_notify_event, see the other _event impls for what to do about the return value
sdroege
approved these changes
Mar 13, 2020
|
@GuillaumeGomez good to go once the CI is happy :) Thanks @tsahyt ! |
|
@GuillaumeGomez time to merge :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some vfuncs that I previously added manually into my subclasses and are still missing.
I've verified that realize and unrealize work as intended. Map and unmap are mostly the same, and should work. I'm not entirely sure about motion_notify_event however, in particular about passing the second argument and whether it should really be mutable.