This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
glib: implement FromGlibContainer for GString #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
commented
Nov 28, 2020
sdroege
reviewed
Nov 28, 2020
sdroege
reviewed
Nov 28, 2020
sdroege
reviewed
Nov 28, 2020
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gstring
branch
from
bc82b52
to
e21b39c
Compare
sdroege
reviewed
Nov 28, 2020
sdroege
reviewed
Nov 28, 2020
sdroege
reviewed
Nov 28, 2020
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gstring
branch
from
e21b39c
to
a0e5a38
Compare
sdroege
reviewed
Nov 29, 2020
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gstring
branch
from
a0e5a38
to
aec5440
Compare
sdroege
reviewed
Nov 29, 2020
sdroege
reviewed
Nov 29, 2020
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gstring
branch
from
aec5440
to
41e2b34
Compare
GString can hold a pointer that might be null and calling slice::from_raw_part on it causes an UB. Instead, we now return an empty string in such case
bilelmoussaoui
force-pushed
the
bilelmoussaoui/gstring
branch
from
ae49c29
to
1e4875e
Compare
sdroege
reviewed
Dec 2, 2020
sdroege
approved these changes
Dec 2, 2020
elmarco
pushed a commit
to elmarco/gtk-rs
that referenced
this pull request
Feb 10, 2021
Regenerate with link attribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by gtk-rs/gtk4-rs#89