Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

gio: add Windows stream types #255

Merged
merged 1 commit into from
Jan 12, 2021
Merged

gio: add Windows stream types #255

merged 1 commit into from
Jan 12, 2021

Conversation

pbor
Copy link
Contributor

@pbor pbor commented Jan 11, 2021

No description provided.

@pbor pbor force-pushed the giow32 branch 2 times, most recently from 9b89ec3 to 0cf480f Compare January 11, 2021 21:10
sdroege
sdroege reviewed Jan 12, 2021
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Did you confirm that it actually compiles and works on Windows?

@pbor
Copy link
Contributor Author

pbor commented Jan 12, 2021

Looks good to me otherwise. Did you confirm that it actually compiles and works on Windows?

Yep. tested in the new CI :)

@sdroege sdroege merged commit 6622d84 into gtk-rs:master Jan 12, 2021
@pbor pbor deleted the giow32 branch January 12, 2021 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@bilelmoussaoui bilelmoussaoui bilelmoussaoui left review comments

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbor @sdroege @GuillaumeGomez @bilelmoussaoui