This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
gio: Rename TlsConnectionManualExt to ExtManual and export from prelude #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rename should he done in Gir.toml as well or otherwise added to the manual_traits list |
MarijnS95
force-pushed
the
gio-move-tls-connection-trait
branch
from
6777f59
to
e4f863a
Compare
Noticed in [1] that this trait has ManualExt written the wrong way around, and is exported from the crate root instead of the prelude where all other traits are reexported. Besides, it has the name the correct way around in the `manual_traits` array inside Gir.toml. [1]: gtk-rs/gir#1111 (comment) Fixes: ad71d74 ("gio: manually generate get_channel_binding_data")
MarijnS95
force-pushed
the
gio-move-tls-connection-trait
branch
from
e4f863a
to
07d421f
Compare
|
@bilelmoussaoui It was already named the correct way around in ^^ |
bilelmoussaoui
approved these changes
Apr 25, 2021
GuillaumeGomez
approved these changes
Apr 25, 2021
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in 1 that this trait has ManualExt written the wrong way around, and is exported from the crate root instead of the prelude where all other traits are reexported.
CC @bilelmoussaoui