Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

gtk/{Text,Tree}Iter: derive Debug #714

Merged
merged 2 commits into from Jan 16, 2022
Merged

Conversation

fengalin
Copy link
Contributor

So that a struct using these types can also auto derive Debug.

Another solution could be to add a Debug impl in manual code,
but since these are iterators, there's not much we can show.

Other boxed_inline candidates in gtk-rs-core and gtk3-rs use manual Debug impl AFAICT.

So that a struct using these types can also auto derive Debug.

Another solution could be to add a Debug impl in manual code,
but since these are iterators, there's not much we can show.
@GuillaumeGomez
Copy link
Member

I wonder if we should do the opposite and derive Debug by default unless set to false...

@fengalin
Copy link
Contributor Author

I wonder if we should do the opposite and derive Debug by default unless set to false...

If I refer to graphen, which uses the most boxed_inlines AFAICT, it makes sense to manually implement. You would either get useless inner indirection or require to manually implement anyway to either call the C accessors or use the proper cast (see quad.rs for instance).

@GuillaumeGomez
Copy link
Member

Good point. :)

cc @sdroege

@sdroege sdroege merged commit d9208b8 into gtk-rs:master Jan 16, 2022
@fengalin fengalin deleted the iter-debug branch January 16, 2022 17:37
fengalin added a commit to fengalin/media-toc that referenced this pull request Jan 19, 2022
Could use previous point releases due to:
gtk-rs/gtk3-rs#714
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants