Regen with latest gir #1421
Closed
Regen with latest gir #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jul 10, 2023
| dyn future::Future<Output = Result<(gio::InputStream, GString), glib::Error>> + 'static, | ||
| >, | ||
| > { | ||
| ) -> Result<(gio::InputStream, GString), glib::Error> { | ||
| let mime_types = mime_types | ||
| .iter() | ||
| .copied() | ||
| .map(String::from) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
This is an API change now btw. The previous version was only borrowing mime_types for the duration of the call, this one is borrowing it until the resulting future is gone.
Not necessarily a problem but something to be aware of.
|
Closing as I don't plan to push this forward any time soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.