Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Check links with lychee #1499

Merged
merged 3 commits into from
Sep 26, 2023
Merged

book: Check links with lychee #1499

merged 3 commits into from
Sep 26, 2023

Conversation

Hofer-Julian
Copy link
Collaborator

No description provided.

@@ -12,7 +12,7 @@ on:

jobs:
build-deploy:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? it is recommended to specify the version iirc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way, will change it back.

Copy link
Member

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you found any broken links thanks to it? otherwise lgtm

@Hofer-Julian
Copy link
Collaborator Author

have you found any broken links thanks to it? otherwise lgtm

Yes, three links were broken :)
Two to gtk4-rs docs and one to app for gnome.

@Hofer-Julian Hofer-Julian merged commit eabd494 into master Sep 26, 2023
2 checks passed
@Hofer-Julian Hofer-Julian deleted the Hofer-Julian/lychee branch September 26, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants