print_job: fix send() closure #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
force-pushed
the
print-job-send
branch
2 times, most recently
from
46b3e51
to
5d6085a
Compare
sdroege
reviewed
Jan 19, 2024
sdroege
reviewed
Jan 19, 2024
pbor
force-pushed
the
print-job-send
branch
3 times, most recently
from
9026968
to
4db289e
Compare
Pass a result, since error is set only on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a result, since error is set only on failure. Also avoid passing the job itself to the rust closure since that is redundant.