Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add example for About Dialog #1589

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

felinira
Copy link
Contributor

@felinira felinira commented Feb 2, 2024

While I was at it I added a small example for using gtk::AboutDialog. I didn't find the logo anywhere else, so I guess it needs to live in the example directory. I opted to use the builder instead of show_about_dialog because of type safety.

Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly. I had a few minor comments.

examples/about_dialog/main.rs Outdated Show resolved Hide resolved
examples/about_dialog/main.rs Outdated Show resolved Hide resolved
examples/about_dialog/main.rs Outdated Show resolved Hide resolved
examples/about_dialog/main.rs Outdated Show resolved Hide resolved
@felinira felinira force-pushed the about_dialog_example branch 2 times, most recently from 5e57b02 to c23d2e4 Compare February 3, 2024 11:20
@bilelmoussaoui bilelmoussaoui merged commit ef50ef8 into gtk-rs:master Feb 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants