New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groovy update: regenerate #19
Conversation
dcfb990
to
8754815
Compare
Ported Solanum using this - looks good to me, based on that. |
Does this branch fix: gtk-rs/examples4#8? |
@toger5 Sort-of. That's fixed at the |
Did another port, using Social (a more complex interface than Solanum) and that worked out as well |
8cd3e69
to
332807b
Compare
now that's merged, let's use it
the latest fedora/ubuntu/debian don't provide us a very up to date gtk4 which makes testing the bindings for the latest stuff impossible. This uses a custom docker image built on top of fedora:latest with gtk3.99.3 built on it along with gtksourceview5 from master The image should be updated to something else once gtk4 is released
Otherwise generally looks good to me, but of course I didn't carefully review every single piece of API. I'm sure there are various wrong annotations that we'll find over time ;) |
34ef6f4
to
043cef0
Compare
043cef0
to
15d018a
Compare
Thanks, looks good for now. Let's get this in and then all further changes on top of this :) |
Thanks 🎉 |
Supersedes #17