Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groovy update: regenerate #19

Merged
merged 45 commits into from Oct 24, 2020

Conversation

bilelmoussaoui
Copy link
Member

Supersedes #17

@bilelmoussaoui bilelmoussaoui changed the title Regenerate groovy update: regenerate Oct 9, 2020
src/subclass/mod.rs Outdated Show resolved Hide resolved
@BrainBlasted
Copy link
Contributor

Ported Solanum using this - looks good to me, based on that.

@toger5
Copy link

toger5 commented Oct 12, 2020

Does this branch fix: gtk-rs/examples4#8?

@BrainBlasted
Copy link
Contributor

@toger5 Sort-of. That's fixed at the sys level

@BrainBlasted
Copy link
Contributor

Did another port, using Social (a more complex interface than Solanum) and that worked out as well

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/update branch 2 times, most recently from 8cd3e69 to 332807b Compare October 18, 2020 23:22
now that's merged, let's use it
the latest fedora/ubuntu/debian don't provide us a very up to date gtk4
which makes testing the bindings for the latest stuff impossible.

This uses a custom docker image built on top of fedora:latest
with gtk3.99.3 built on it along with gtksourceview5 from master

The image should be updated to something else once gtk4 is released
Gir.toml Show resolved Hide resolved
Gir.toml Outdated Show resolved Hide resolved
src/auto/string_object.rs Outdated Show resolved Hide resolved
src/auto/builder_cscope.rs Outdated Show resolved Hide resolved
@sdroege
Copy link
Member

sdroege commented Oct 20, 2020

Otherwise generally looks good to me, but of course I didn't carefully review every single piece of API. I'm sure there are various wrong annotations that we'll find over time ;)

@sdroege
Copy link
Member

sdroege commented Oct 24, 2020

Thanks, looks good for now. Let's get this in and then all further changes on top of this :)

@sdroege sdroege merged commit e2240d0 into gtk-rs:master Oct 24, 2020
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/update branch October 24, 2020 11:27
@bilelmoussaoui
Copy link
Member Author

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants