Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk: make sure gtk::disable_setlocale has to be called before gtk::init() #196

Merged
merged 1 commit into from Feb 28, 2021
Merged

gtk: make sure gtk::disable_setlocale has to be called before gtk::init() #196

merged 1 commit into from Feb 28, 2021

Conversation

Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Feb 27, 2021

fixes #195

bilelmoussaoui
bilelmoussaoui reviewed Feb 27, 2021
View reviewed changes
gtk4/Gir.toml Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui mentioned this pull request Feb 28, 2021
Merged
@Cogitri
Copy link
Contributor Author

Cogitri commented Feb 28, 2021

More cleanup in #198

@bilelmoussaoui
Copy link
Member

This will currently fail until #197 is merged, see the 2nd commit which contains a fix of the examples.

@Cogitri Cogitri mentioned this pull request Feb 28, 2021
Merged
@bilelmoussaoui
Copy link
Member

Do you mind rebasing this one? :-)

@Cogitri
Copy link
Contributor Author

Cogitri commented Feb 28, 2021

Rebased

@bilelmoussaoui bilelmoussaoui merged commit c0a87cc into gtk-rs:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

@bilelmoussaoui bilelmoussaoui bilelmoussaoui left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtk::disable_setlocale() shouldn't panic if called before gtk::init()
3 participants
@Cogitri @bilelmoussaoui @sdroege