Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Add chapter about todo_app_2 #620

Merged
merged 12 commits into from Oct 20, 2021
Merged

book: Add chapter about todo_app_2 #620

merged 12 commits into from Oct 20, 2021

Conversation

Hofer-Julian
Copy link
Collaborator

@Hofer-Julian Hofer-Julian commented Oct 14, 2021

This PR adds a chapter where the To-Do app learns the ability to filter tasks and keep tasks between sessions.

@Hofer-Julian Hofer-Julian force-pushed the Hofer-Julian/todo-2 branch 2 times, most recently from 9d23bd7 to e15c3c5 Compare October 17, 2021 12:05
@Hofer-Julian Hofer-Julian marked this pull request as ready for review October 18, 2021 20:54
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
book/src/todo_app_2.md Show resolved Hide resolved
<span class="filename">Filename: listings/todo_app/2/window/mod.rs</span>

```rust ,no_run,noplayground
{{#rustdoc_include ../listings/todo_app/2/window/mod.rs:restore_data}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also lines a bit too long

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I also don't like this.
I looked a bit into enforcing a shorter line length with rust-fmt only for the book (so I don't annoy @bilelmoussaoui too much).
It's possible by adding an extra rustfmt.toml in the book dir and adding boilerplate to the CI.
Not sure though if that breaks then with e.g. IDE formatting.

book/src/todo_app_2.md Show resolved Hide resolved
book/src/todo_app_2.md Outdated Show resolved Hide resolved
@Hofer-Julian Hofer-Julian merged commit e8a285b into master Oct 20, 2021
@Hofer-Julian Hofer-Julian deleted the Hofer-Julian/todo-2 branch October 20, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants