Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parents #62

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 24, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 24, 2018

Don't updated sys's version

git diff -R --exit-code
diff --git b/sourceview-sys/versions.txt a/sourceview-sys/versions.txt
index 58ce3b7..09d7af0 100644
--- b/sourceview-sys/versions.txt
+++ a/sourceview-sys/versions.txt
@@ -1,2 +1,2 @@
-Generated by gir (https://github.com/gtk-rs/gir @ 464833e)
+Generated by gir (https://github.com/gtk-rs/gir @ 04c26a8)
 from gir-files (https://github.com/gtk-rs/gir-files @ b8f5ef1)
make: *** [regen_check] Error 1
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 24, 2018

👍 after nit fixed

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:missing-parents branch from 0f4cdc6 to d7de82a Aug 24, 2018

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 24, 2018

Seems good :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Aug 24, 2018

Then I merge. Thanks for your reviews!

@GuillaumeGomez GuillaumeGomez merged commit f06330e into gtk-rs:master Aug 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:missing-parents branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.