This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Missing parents #62
Merged
Missing parents #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't updated sys's version git diff -R --exit-code
diff --git b/sourceview-sys/versions.txt a/sourceview-sys/versions.txt
index 58ce3b7..09d7af0 100644
--- b/sourceview-sys/versions.txt
+++ a/sourceview-sys/versions.txt
@@ -1,2 +1,2 @@
-Generated by gir (https://github.com/gtk-rs/gir @ 464833e)
+Generated by gir (https://github.com/gtk-rs/gir @ 04c26a8)
from gir-files (https://github.com/gtk-rs/gir-files @ b8f5ef1)
make: *** [regen_check] Error 1 |
|
👍 after nit fixed |
GuillaumeGomez
force-pushed
the
missing-parents
branch
from
0f4cdc6
to
d7de82a
Compare
|
Seems good :) |
|
Then I merge. Thanks for your reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sdroege @EPashkin