Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package importer changed from default to source #10

Closed
wants to merge 1 commit into from

Conversation

alexgivi
Copy link

@alexgivi alexgivi commented May 2, 2023

There was a problem when working with project located in private repository. Default importer usage caused panic after checking file error because of unability to import from private repo. Changing importer from Default to source fixes the problem.

@gtramontina
Copy link
Owner

Hey there @alexgivi! 👋 Thanks for giving it a crack! This is related to #9.

Unfortunately it seems to be more involved than changing to source. Indeed, it goes further and may even be enough for many situations. But it fails to handle scenarios where a function is called in one file but declared on a different file that hasn't been processed yet (you'll get what I'm saying if you run make test.mutation on your fork of Ooze).

I believe that in order to solve this problem we may need to re-think how we infect files. Also, this check is quite expensive to run for every infection; this contributes to having to re-think how infecting happens (memoization at some point).

I'm even considering dropping v0.3.0 (v0.2.0 works well, but without the CancelNil virus) until this can be properly addressed.

Thoughts? 💭

cc/ @blizzy78

@blizzy78
Copy link
Contributor

blizzy78 commented May 3, 2023

I believe that in order to solve this problem we may need to re-think how we infect files.

Yes. I'm working on that currently, and so far it looks quite promising, but it's not ready yet.
I seem to be running into some flaky tests in Ooze itself, but not quite sure yet.

I'm even considering dropping v0.3.0 (v0.2.0 works well, but without the CancelNil virus) until this can be properly addressed.

Agreed. The best course of action should be to disable CancelNil in the default list of viruses, as well as passing nil for type infos, then release a new version with a retraction of 0.3.0 in go.mod.

Sorry for causing hickups 😅

@gtramontina
Copy link
Owner

gtramontina commented May 4, 2023

Sorry for causing hickups 😅

No worries! Version control systems exist for a good reason. 😄

I'll go ahead an release a retraction soon! Done.

Good if we close this PR, @alexgivi?

Cheers!

@alexgivi
Copy link
Author

alexgivi commented May 4, 2023

yes, i don't mind, thanks for care.

@gtramontina gtramontina closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants