Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] The documentRef GraphQL field is populated by the collectors #1846

Closed
nchelluri opened this issue Apr 16, 2024 · 0 comments · Fixed by #1847
Closed

[feature] The documentRef GraphQL field is populated by the collectors #1846

nchelluri opened this issue Apr 16, 2024 · 0 comments · Fixed by #1847
Labels
enhancement New feature or request

Comments

@nchelluri
Copy link
Contributor

nchelluri commented Apr 16, 2024

Is your feature request related to a problem? Please describe.
After closing #1833 we now have a DocumentRef field in the SourceInformation type that corresponds to the documentRef field in GraphQL verb nodes. The next (and last) step is to populate this field. As part of this work we also want to undo the overloading of the GraphQL origin field that was performed in the recently created --use-blob-url CLI flag for the File collector (done in #1811) and leave origin as it was prior that work and store the blob key only (and always) in the new documentRef field. I am also suggesting that we switch to using the term "blob key" as that seems to match the terminology used in the method signature here: https://pkg.go.dev/gocloud.dev/blob?utm_source=godoc#Bucket.NewWriter

This work is a follow-up to #1844. It is aimed to ease reingestion of documents.

Describe the solution you'd like
The collectors should populate the SourceInformation.DocumentRef field with the blob key (an example value for the field is sha256:4c47f63847cd2b73d77f9008bb8bfa359e6201205004a2c26048a8711fd1c746).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant