Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gql, parser and backends to add new documentRef field #1844

Merged
merged 10 commits into from Apr 16, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Apr 15, 2024

Description of the PR

Add new documentRef field to graphQL schema, updates the parsers and all backends. Unit tests added to test new field.

closes #1833

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 force-pushed the issue-1833-update-backends branch 2 times, most recently from e8f0880 to 99fdc59 Compare April 15, 2024 22:46
@pxp928
Copy link
Collaborator Author

pxp928 commented Apr 15, 2024

This PR ended up bigger than I would have liked :(

@pxp928 pxp928 force-pushed the issue-1833-update-backends branch 3 times, most recently from 722609b to 160e8c1 Compare April 15, 2024 23:07
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 force-pushed the issue-1833-update-backends branch from 160e8c1 to 0192762 Compare April 15, 2024 23:11
nchelluri added a commit to nchelluri/guac that referenced this pull request Apr 16, 2024
- this branch is based off of 4c47f63847cd2b73d77f9008bb8bfa359e6201205004a2c26048a8711fd1c746
  which is the current head of pxp928:issue-1833-update-backends (guacsec#1844)
  - it will need to rebased onto main when guacsec#1844 is merged!

Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue for the indexes in the Certification Ent entity.

pkg/assembler/backends/ent/schema/certification.go Outdated Show resolved Hide resolved
Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pxp928 thanks a lot 👍

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 6638a53 into guacsec:main Apr 16, 2024
8 checks passed
@pxp928 pxp928 deleted the issue-1833-update-backends branch April 16, 2024 18:28
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
…ec#1844)

* change documentRef to mandatory

Signed-off-by: pxp928 <parth.psu@gmail.com>

* udpate keyvalue backend for documnetRef

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update ent with document_ref

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update predicate querying ent

Signed-off-by: pxp928 <parth.psu@gmail.com>

* implement docref for all verb nodes for ent

Signed-off-by: pxp928 <parth.psu@gmail.com>

* implement docref for all verb nodes for arango

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update backend tests for docref

Signed-off-by: pxp928 <parth.psu@gmail.com>

* updates based on unit test

Signed-off-by: pxp928 <parth.psu@gmail.com>

* update examples with docref

Signed-off-by: pxp928 <parth.psu@gmail.com>

* remove duplicate docref from certification index

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add new field to store document reference for persistent storage
3 participants