-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gql, parser and backends to add new documentRef
field
#1844
Conversation
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
e8f0880
to
99fdc59
Compare
This PR ended up bigger than I would have liked :( |
722609b
to
160e8c1
Compare
Signed-off-by: pxp928 <parth.psu@gmail.com>
160e8c1
to
0192762
Compare
- this branch is based off of 4c47f63847cd2b73d77f9008bb8bfa359e6201205004a2c26048a8711fd1c746 which is the current head of pxp928:issue-1833-update-backends (guacsec#1844) - it will need to rebased onto main when guacsec#1844 is merged! Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue for the indexes in the Certification
Ent entity.
Signed-off-by: pxp928 <parth.psu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pxp928 thanks a lot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…ec#1844) * change documentRef to mandatory Signed-off-by: pxp928 <parth.psu@gmail.com> * udpate keyvalue backend for documnetRef Signed-off-by: pxp928 <parth.psu@gmail.com> * update ent with document_ref Signed-off-by: pxp928 <parth.psu@gmail.com> * update predicate querying ent Signed-off-by: pxp928 <parth.psu@gmail.com> * implement docref for all verb nodes for ent Signed-off-by: pxp928 <parth.psu@gmail.com> * implement docref for all verb nodes for arango Signed-off-by: pxp928 <parth.psu@gmail.com> * update backend tests for docref Signed-off-by: pxp928 <parth.psu@gmail.com> * updates based on unit test Signed-off-by: pxp928 <parth.psu@gmail.com> * update examples with docref Signed-off-by: pxp928 <parth.psu@gmail.com> * remove duplicate docref from certification index Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Description of the PR
Add new
documentRef
field to graphQL schema, updates the parsers and all backends. Unit tests added to test new field.closes #1833
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run