Add guaccollect files option to set origin to blob path #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
- They are actually blob URLs, so this is slightly more accurate, and a touch shorter. Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
jeffmendoza
approved these changes
Apr 4, 2024
pxp928
approved these changes
Apr 4, 2024
arorasoham9
pushed a commit
to arorasoham9/guac
that referenced
this pull request
May 17, 2024
* Add guaccollect files option to set origin to blob path Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev> * Change nomenclature: "blob path" -> "blob URL" - They are actually blob URLs, so this is slightly more accurate, and a touch shorter. Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev> * Update field comment and CLI arg desc to be more useful Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev> --------- Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev> Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
When the new
--use-blob-urlcommand line arg is set, the created nodes will have an origin whose value is the blob URL, instead of the source URL.To test this, I ran
go run ./cmd/guacone collect files ~/Downloads/demo.json,go run ./cmd/guaccollect files ~/Downloads/demo.json --service-poll=false, andgo run ./cmd/guaccollect files ~/Downloads/demo.json --service-poll=false --use-blob-url. (guacingestandguacgqlwere running first, anddemo.jsonis a small sample SPDX SBOM file.) In each case the command completed successfully and the HasSBOM node looked ok to me in the GraphQL Playground. I also expanded the File Collector automated test.(Please see #1806 which this basically is, plus changes requested during the last review. I didn't realize that if I changed the branch name using the GitHub interface it would close my old PR, but it did.)
PR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run