Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for docker compose #1176

Merged
merged 2 commits into from Aug 22, 2023
Merged

Conversation

s-spindler
Copy link
Contributor

Description of the PR

If you don't have docker compose correctly linked to in the ~/.docker/cli-plugins directory you get a misleading error message: unknown flag: --force-recreate.

The additional check gives a more helpful (I hope) error message.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
    - [ ] All new changes are covered by tests
    - [ ] If GraphQL schema is changed, make generate has been run
    - [ ] If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
    - [ ] All dependent PRs have already been merged

Signed-off-by: Pinto Spindler, Stephan <25225092+s-spindler@users.noreply.github.com>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Pinto Spindler, Stephan <25225092+s-spindler@users.noreply.github.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 2290eb0 into guacsec:main Aug 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants