Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for docker compose #1176

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Add check for docker compose #1176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b59ccd5
Add check for docker compose
s-spindler Aug 21, 2023
26434a5
Reference docker by variable
s-spindler Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 11 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ container: check-docker-tool-check check-docker-buildx-tool-check check-goreleas
# To run the service, run `make container` and then `make service`
# making the container is a longer process and thus not a dependency of service.
.PHONY: start-service
start-service:
start-service: check-docker-compose-tool-check
# requires force recreate since docker compose reuses containers and neo4j does
# not handle that well.
#
Expand All @@ -146,11 +146,19 @@ check-docker-tool-check:
# Check that docker buildx is installed.
.PHONY: check-docker-buildx-tool-check
check-docker-buildx-tool-check:
@if ! docker buildx >/dev/null 2>&1; then \
@if ! $(CONTAINER) buildx >/dev/null 2>&1; then \
echo "'$(CONTAINER)' buildx is not installed. Please install '$(CONTAINER)' buildx and try again."; \
exit 1; \
fi

# Check that docker compose is installed.
.PHONY: check-docker-compose-tool-check
check-docker-compose-tool-check:
@if ! $(CONTAINER) compose >/dev/null 2>&1; then \
echo "'$(CONTAINER)' compose is not installed or not correctly linked to. Please install '$(CONTAINER)' compose or link it as a plugin and try again."; \
exit 1; \
fi

# Check that protoc is installed.
.PHONY: check-protoc-tool-check
check-protoc-tool-check:
Expand Down Expand Up @@ -184,4 +192,4 @@ check-goreleaser-tool-check:

# Check that all the tools are installed.
.PHONY: check-tools
check-tools: check-docker-tool-check check-docker-buildx-tool-check check-protoc-tool-check check-golangci-lint-tool-check check-mockgen-tool-check check-goreleaser-tool-check
check-tools: check-docker-tool-check check-docker-buildx-tool-check check-docker-compose-tool-check check-protoc-tool-check check-golangci-lint-tool-check check-mockgen-tool-check check-goreleaser-tool-check