Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'integration' tag to golangci-lint #1202

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Aug 30, 2023

Description of the PR

Added integration custom tag to .golangci.yaml configuration to solve CI Lint failure on main branch (ref. https://github.com/guacsec/guac/actions/runs/6021675765/job/16334972954):

golangci-lint run
pkg/assembler/backends/ent/backend/query_helpers.go:37:6: func `pkgTreeFromVersion` is unused (unused)
func pkgTreeFromVersion(ctx context.Context, pv *ent.PackageVersion) (*ent.PackageType, error) {
     ^
pkg/assembler/backends/ent/backend/query_helpers.go:72:6: func `buildPackageTreeQuery` is unused (unused)
func buildPackageTreeQuery(q *ent.PackageTypeQuery, ns, packageName string, pv *ent.PackageVersion) {
     ^

since methods are used from

pkgTree, err := pkgTreeFromVersion(s.Ctx, pkgVersion)
which has the //go:build integration tag

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: mrizzi <mrizzi@redhat.com>
@mrizzi
Copy link
Collaborator Author

mrizzi commented Aug 30, 2023

tilt ci job is expected to fail.
Fixed in #1201

@kodiakhq kodiakhq bot merged commit 3f96625 into guacsec:main Aug 30, 2023
8 of 9 checks passed
@mrizzi mrizzi deleted the fix-ci-lint branch August 30, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants