Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IngestVEXStatement resolver: fix err management #1203

Merged
merged 1 commit into from Aug 30, 2023
Merged

IngestVEXStatement resolver: fix err management #1203

merged 1 commit into from Aug 30, 2023

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Aug 30, 2023

Description of the PR

Fix err management after having called the backend

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

pxp928
pxp928 previously approved these changes Aug 30, 2023
View reviewed changes
@pxp928 pxp928 dismissed their stale review August 30, 2023 13:43

more changes

pxp928
pxp928 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrizzi
IngestVEXStatement: fix err management
44ca017 
Signed-off-by: mrizzi <mrizzi@redhat.com>
@mrizzi
Copy link
Collaborator Author

mrizzi commented Aug 30, 2023

tilt ci job is expected to fail.
Fixed in #1201

@kodiakhq kodiakhq bot merged commit c1413ad into guacsec:main Aug 30, 2023
8 of 9 checks passed
@mrizzi mrizzi deleted the fix-IngestVEXStatement branch August 30, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrizzi @jeffmendoza @pxp928