Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ent on 32 bit #1226

Merged
merged 3 commits into from Sep 7, 2023
Merged

Disable ent on 32 bit #1226

merged 3 commits into from Sep 7, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Description of the PR

Disable ent on 32 bit

supersedes #1201

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Disable ent on 32 bit
43393ce 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@jeffmendoza jeffmendoza mentioned this pull request Sep 5, 2023
Closed
mihaimaruseac
mihaimaruseac approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this refactoring! 💯

cmd/guacgql/cmd/server.go Outdated Show resolved Hide resolved
lumjjb
lumjjb approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments

cmd/guacgql/cmd/server.go Show resolved Hide resolved
cmd/guacgql/cmd/ent.go Show resolved Hide resolved
@jeffmendoza
Remove done todo.
dbcde6a 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 5, 2023
@jeffmendoza
Add registrations for backends
144d045 
Simplify code in guacgql-server. Backends all register their own Get func and
must simply take a config struct. Setup "Neptune" backend with init func.

Signed-off-by: Jeff Mendoza <jlm@jlm.name>
@kodiakhq kodiakhq bot merged commit 4dfaf8b into guacsec:main Sep 7, 2023
9 checks passed
@jeffmendoza jeffmendoza mentioned this pull request Sep 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeffmendoza @mihaimaruseac @lumjjb @pxp928