Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inmem unit test. #1235

Merged
merged 1 commit into from Sep 7, 2023
Merged

Fix inmem unit test. #1235

merged 1 commit into from Sep 7, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Copy link
Collaborator Author

#1226 and #1227 broke unit tests once merged together.

@jeffmendoza
Fix inmem unit test.
34c8940 
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
pxp928
pxp928 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised it didn't have a merge conflict..

@jeffmendoza
Copy link
Collaborator Author

The same lines didn't change, just each built/tested fine on their own, but broke once merged together. =)

@kodiakhq kodiakhq bot merged commit c035663 into guacsec:main Sep 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffmendoza @lumjjb @pxp928