Improved Runtime of Function Process in process.go #1245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Fixes: #1225
This PR addresses the performance issue raised in #1225 regarding the noticeable performance drawbacks when handling deeply nested structures in the
processHelper
function.Changes:
processHelper
from a recursive function to an iterative approach. However, this change did not yield significant runtime improvements.Unpack
function, which utilizedencoding/json
, was the primary contributor to the extended runtime.encoding/json
tojson-iterator/go
for JSON operations, resulting in a significant runtime improvement.Benchmark Results:
Test case used for benchmarking:
encoding/json
: Document processed in 29.227243671sjson-iterator/go
: Document processed in 9.27833562sAs observed,
json-iterator/go
reduced the runtime by approximately two-thirds.PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run