Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JSON encoder from encoding/json to json-iterator/go #1250

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

neilnaveen
Copy link
Contributor

@neilnaveen neilnaveen commented Sep 11, 2023

Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@mihaimaruseac
Copy link
Collaborator

+1 to replacing the dependency throughout the entire codebase. It looks like the entire change is an import replacement.

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilnaveen for the hard work on this! Appreciate the effort and should greatly improve our overall performance based on a library change.

cmd/guacone/cmd/collectsub_client.go Outdated Show resolved Hide resolved
internal/testing/cmd/pubsub_test/cmd/files.go Outdated Show resolved Hide resolved
@neilnaveen
Copy link
Contributor Author

Thanks @neilnaveen for the hard work on this! Appreciate the effort and should greatly improve our overall performance based on a library change.

Thank you for the support and the encouragement!

- updated encoding/json to json-iterator/go for perf

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neilnaveen good work!

@kodiakhq kodiakhq bot merged commit a79ec2e into guacsec:main Sep 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants