-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed JSON encoder from encoding/json to json-iterator/go #1250
Conversation
+1 to replacing the dependency throughout the entire codebase. It looks like the entire change is an import replacement. |
6f7de04
to
ad324e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neilnaveen for the hard work on this! Appreciate the effort and should greatly improve our overall performance based on a library change.
ad324e4
to
62bacb9
Compare
Thank you for the support and the encouragement! |
62bacb9
to
4c8136f
Compare
- updated encoding/json to json-iterator/go for perf Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
4c8136f
to
9a3108d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neilnaveen good work!
Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com
Description of the PR
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run