Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Keys method in kv interface to Scan #1558

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Change Keys method in kv interface to Scan #1558

merged 1 commit into from
Dec 5, 2023

Conversation

jeffmendoza
Copy link
Collaborator

Keys was a placeholder, as an external keyvalue may have more keys than we want to read at once. Additionally we don't want to overload the external store with an operation that will block for a long time. Now the Scan interface will only get some number of keys at a time. Implementations for Redis and TiKV have been added.

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@jeffmendoza
Change Keys method in kv interface to Scan
baff27c 
Keys was a placeholder, as an external keyvalue may have more keys than we want
to read at once. Additionally we don't want to overload the external store with
an operation that will block for a long time. Now the Scan interface will only
get some number of keys at a time. Implementations for Redis and TiKV have been
added.

Signed-off-by: Jeff Mendoza <jlm@jlm.name>
pxp928
pxp928 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks good!

@kodiakhq kodiakhq bot merged commit 18ad0d0 into guacsec:main Dec 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffmendoza @mihaimaruseac @pxp928