Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[update-arango-graph] - creates a missing collection in already pr… #1649

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

kanchan-dhamane
Copy link
Contributor

@kanchan-dhamane kanchan-dhamane commented Jan 21, 2024

Description of the PR

Adds the check to ensure that required edge collection are present in ArangoDB graph and if any edge collection is missing, it will create the edge collection

"Fixes #1648"

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

…esent graph - 1648

Signed-off-by: Kanchan Dhamane <dhamane.kanchan@gmail.com>
Signed-off-by: Kanchan Dhamane <dhamane.kanchan@gmail.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanchan-dhamane! Great addition and improvement for backwards compatibility.

@kodiakhq kodiakhq bot merged commit f1703bd into guacsec:main Jan 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Automated Graph Update for ArangoDB Backend on Collection Addition
3 participants