Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new re-designed overview diagram for GUAC #1831

Merged
merged 2 commits into from
Apr 11, 2024
Merged

add new re-designed overview diagram for GUAC #1831

merged 2 commits into from
Apr 11, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Apr 9, 2024

Description of the PR

add new re-designed overview diagram for GUAC

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Copy link
Contributor

@pxp928 In the new image, there is a red underline on "OpenSSF Scorecard" because of a supposed spelling issue. Should we fix this? I assume that we don't want that in the design diagram for GUAC.

@pxp928
Copy link
Collaborator Author

pxp928 commented Apr 9, 2024

@pxp928 In the new image, there is a red underline on "OpenSSF Scorecard" because of a supposed spelling issue. Should we fix this? I assume that we don't want that in the design diagram for GUAC.

oh let me fix that

@pxp928
add new re-designed overview diagram for GUAC
c72ca3c 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
Copy link
Collaborator Author

pxp928 commented Apr 9, 2024

Thanks @nathannaveen fixed the red underline

lumjjb
lumjjb requested changes Apr 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pxp928
fix copyright
61097c5 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 requested a review from lumjjb April 11, 2024 19:01
@kodiakhq kodiakhq bot merged commit 3dba718 into guacsec:main Apr 11, 2024
8 checks passed
@pxp928 pxp928 deleted the update-diagram-readme branch April 11, 2024 20:36
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
@pxp928 @arorasoham9
add new re-designed overview diagram for GUAC (guacsec#1831)
bd2a23c 
* add new re-designed overview diagram for GUAC

Signed-off-by: pxp928 <parth.psu@gmail.com>

* fix copyright

Signed-off-by: pxp928 <parth.psu@gmail.com>

---------

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxp928 @nathannaveen @mihaimaruseac @lumjjb