Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move timestamp up such that it is not skipped #2046

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jul 22, 2024

Description of the PR

there is a situation that can cause the deps.dev collector to not add the timestamp. This can cause the error:

error: unable to ingest document due to ingestion error deps.dev : error assembling graphs for \"deps.dev\" : hasSBOMPkgs failed with error: input: ingestHasSBOMs hasSBOMS contains a zero time\n","errorType":"wrapError"}

This PR moves the timestamp assignment at the beginning of the function such that it is never skipped.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 requested a review from lumjjb July 24, 2024 16:33
@kodiakhq kodiakhq bot merged commit 0c6dc86 into guacsec:main Jul 25, 2024
8 checks passed
@pxp928 pxp928 deleted the fix_deps_dev_timestamp branch July 25, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants